-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP: plumb through GCP info to our download page #494
Comments
Is the URL publicly accessible, I got a "403 Forbidden" when accessing it.. |
Try again :) - I tweaked some settings. |
|
Might be related but should we consider limiting the number of AWS regions shown since right now AWS is overwhelming other cloud platform (xref: https://pagure.io/fedora-websites/issue/964#comment-578973). For example, an option will be to hide other regions and add a button to show more regions. But I'm not sure which regions are more popular than others. |
Yes please! Options:
Also, can we make the |
Yes I agree with the idea. Also I'd like to experiment with the options above to see which works better. |
Related: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
I really like the idea of collapsing all the AWS regions into a single block with a region-selector dropdown. @dustymabe, what's your reasoning for exposing the image ID? AWS is special, since users must know an individual image ID in order to launch an instance. On other clouds, I don't feel great about helping users hardcode image IDs in their infrastructure. They can always query the image family themselves if they want to get an ID to hardcode. Also, is there any value to publishing the GS URL? Isn't it an exact copy of the tar.gz from our artifact bucket, and deleted after image creation is complete? |
👍
I definitely think we should highlight and prefer the image family usage, but I would like to also include the image name information, even if we put it behind some clickable popup or otherwise make it less prominent. As you point out users can still get the image name if they want it and I'd prefer to have that information in a logical place where they find all the other information about a release. This is only my opinion. I'm interested in what others think.
It's the same file. It used to be deleted within a day (garbage collection), but @vrutkovs highlighted the fact that OKD (like OCP) doesn't use the images we create directly, but rather the GCS file to then create an image. I've got some conversations going on to try to change this in the future. So.. we could decide to not publish the GCS file on the website now, and then also stop putting it in the meta.json at all when OKD stops using it directly (assuming that happens). |
Makes sense. I think I could live with the idea of burying it under some UI. I'm also interested in others' thoughts.
👍 We can always add it to stream metadata later. Removing it is harder. |
Related: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
Related: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
Related: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
Related: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
Adds GCP cloud launchable name, family and project on the download page. This works along side with - coreos/fedora-coreos-releng-automation#112 to add GCP info in release.json - coreos/fedora-coreos-stream-generator#11 to add GCP info in ${stream}.json This change reads metadata from ${stream}.json and renders it. It is also possible to read directly from individual meta.json file but since the download page is already utilizing ${stream}.json, this changes is trying to make use of already fetched metadata instead of fetching another meta.json. Closes: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
Related: coreos/fedora-coreos-tracker#494 Signed-off-by: Allen Bai <abai@redhat.com>
This is done now. Thanks for the hard work @zonggen ! |
There were a flurry of PRs over the past few weeks to get GCP images created in GCP itself for users to use. Now that we have those we should update the Cloud Launchable tab to include some information about the GCP images.
The entry in the meta.json looks like:
We'll want to plumb some of that information through the stream metadata and then display it for the user to use. While I think it is important to include the image name in the downloads web UI we should also note that image families exist and we should encourage the use of them so that the users automatically get new images when they are released.
The text was updated successfully, but these errors were encountered: