Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new podman with quadlet functionality #998

Closed
deuill opened this issue Oct 17, 2021 · 22 comments · Fixed by coreos/fedora-coreos-config#2216
Closed

Include new podman with quadlet functionality #998

deuill opened this issue Oct 17, 2021 · 22 comments · Fixed by coreos/fedora-coreos-config#2216

Comments

@deuill
Copy link

deuill commented Oct 17, 2021

Please try to answer the following questions about the package you are requesting:

  1. What, if any, are the additional dependencies on the package? (i.e. does it pull in Python, Perl, etc)
    Requires podman and crun, both of which are provided in base already.

  2. What is the size of the package and its dependencies?
    Unsure, though likely less that 50kB.

  3. What problem are you trying to solve with this package? Or what functionality does the package provide?
    Integrating Podman with systemd requires that either podman generate systemd is used (which presupposes a Podman container, isn't as configurable, and produces files that aren't intended for further editing), or that equivalent integration is done manually and in a repeated manner. Quadlet solves the issue of integration with systemd as a starting point in a much more elegant way.

  4. Can the software provided by the package be run from a container? Explain why or why not.
    This is intended to be used on the base system itself, and generates service files that themselves orchestrate Podman containers.

  5. Can the tool(s) provided by the package be helpful in debugging container runtime issues?
    Likely not, though they will likely help alleviate issues with misconfigured integrations.

  6. Can the tool(s) provided by the package be helpful in debugging networking issues?
    I don't believe so.

  7. Is it possible to layer the package onto the base OS as a day 2 operation? Explain why or why not.
    It's possible, though unwieldy for such a small utility.

  8. In the case of packages providing services and binaries, can the packaging be adjusted to just deliver binaries?
    This will likely only provide a binary and related support files for systemd generators.

  9. Can the tool(s) provided by the package be used to do things we’d rather users not be able to do in FCOS? (e.g. can it be abused as a Turing complete interpreter?)
    I don't believe so.

  10. Does the software provided by the package have a history of CVEs?
    It does not, though it's a fairly young project.

@deuill
Copy link
Author

deuill commented Oct 17, 2021

I'm sure this is on someone's radar already, but I didn't find any issue for this so I thought I'd make one -- Quadlet seems like a pretty awesome addition to the container ecosystem, and would make my life (and I suspect other people's lives as well) of using CoreOS as a single-node home-server much simpler.

There's discussion on integrating Quadlet into Podman itself, which would make any separate integration in CoreOS moot, but those discussions are somewhat nebulous and probably come at a higher cost (in terms of maintenance) than integration here.

I'm also not sure if this is actually packaged.

@lucab
Copy link
Contributor

lucab commented Oct 17, 2021

For reference, initial discussion was at https://discussion.fedoraproject.org/t/what-does-everyone-think-of-quadlet/33403.

@dustymabe
Copy link
Member

There's discussion on integrating Quadlet into Podman itself,

Yeah that would be awesome. It would also me nice to have the interface stabilize before we introduce it in FCOS so people don't break on upgrade. Would need to reach out to the devs to get a confidence level on that.

I'm also not sure if this is actually packaged.

yep. definitely need it packaged first.

@travier
Copy link
Member

travier commented Mar 23, 2022

I'm +1 for including quadlet as this closes a usability gap for single node / non cluster deployments by making container management with podman much easier.

Also agree that we should wait until we have confidence that the interface will be relatively stable going forward.

I would have preferred to not add more C code to FCOS (Rust or Go would be great here) but this should not be security critical so this would be OK.

@dustymabe
Copy link
Member

Would be nice to sync up with quadlet devs and podman team again on future here. @travier could you reach out?

@travier travier self-assigned this Apr 12, 2022
@travier travier removed their assignment Jul 22, 2022
@travier
Copy link
Member

travier commented Jul 22, 2022

Clearing assignee as I'm not actively working on this

@LorbusChris
Copy link
Contributor

It looks like work to port quadlet to go, and add it to podman, is on its way: containers/quadlet#41

@ibotty
Copy link

ibotty commented Dec 3, 2022

This is now obsolete because it's part of the next podman release. This issue can be closed.

ref: containers/podman#16035

@dustymabe
Copy link
Member

Will close this out once podman with the new functionality hits FCOS.

@dustymabe dustymabe changed the title New Package Request: quadlet Include new podman with quadlet functionality Dec 5, 2022
@dustymabe dustymabe added the status/pending-upstream-release Fixed upstream. Waiting on an upstream component source code release. label Dec 5, 2022
@travier
Copy link
Member

travier commented Dec 5, 2022

containers/podman#16035 > This has been merged 🎉 So this will likely come in the next podman release (might still be a sub package).

@lukasmrtvy
Copy link

quadlet is now included in 4.4.0 https://github.com/containers/podman/releases/tag/v4.4.0-rc3

@dustymabe
Copy link
Member

Yep. That's an rc3, though. When it hits actual 4.4.0 we'll pick it up.

@travier
Copy link
Member

travier commented Feb 3, 2023

@travier
Copy link
Member

travier commented Feb 3, 2023

We have to make a PR to add the -quadlet subpackage: https://src.fedoraproject.org/rpms/podman/blob/rawhide/f/podman.spec#_314

@travier
Copy link
Member

travier commented Feb 3, 2023

Would be great if folks interested by this functionality would make a test for it (that includes me 🙂).

@travier
Copy link
Member

travier commented Feb 3, 2023

Trying this in coreos/fedora-coreos-config#2216.

@dustymabe
Copy link
Member

Trying this in coreos/fedora-coreos-config#2216.

Since 4.4.0 just got released and our next round of FCOS releases is approximately next Tuesday, I'm thinking maybe we should hold this until at least the RPM has passed bodhi stable before we ship it in testing.

Of course, we should run it through our CI to get any early feedback on it (as is already being done in coreos/fedora-coreos-config#2216).

WDYT?

@travier
Copy link
Member

travier commented Feb 3, 2023

Definitely agree to not fast-track this one. My PR is doing that only in order to be able to test it now.

travier added a commit to travier/fedora-coreos-config that referenced this issue Feb 3, 2023
We only include it for Fedora CoreOS as this likely won't be included in
RHCOS.

Fixes: coreos/fedora-coreos-tracker#998
@dustymabe
Copy link
Member

Definitely agree to not fast-track this one. My PR is doing that only in order to be able to test it now.

Now that this week's releases are out of the way I propose we go ahead and get this in testing-devel for more testing.

It won't ship in testing until the 21st anyway.

@travier travier added status/pending-testing-release Fixed upstream. Waiting on a testing release. component/podman and removed status/pending-upstream-release Fixed upstream. Waiting on an upstream component source code release. labels Feb 10, 2023
@dustymabe dustymabe added the status/pending-next-release Fixed upstream. Waiting on a next release. label Feb 10, 2023
@dustymabe
Copy link
Member

The fix for this went into next stream release 37.20230218.1.0. Please try out the new release and report issues.

@dustymabe
Copy link
Member

The fix for this went into testing stream release 37.20230218.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. status/pending-next-release Fixed upstream. Waiting on a next release. labels Feb 22, 2023
@dustymabe
Copy link
Member

The fix for this went into stable stream release 37.20230218.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants