design: add aws section to cloud agents #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we make the whitespace changes in a separate commit? |
dustymabe
reviewed
Jan 9, 2019
Design.md
Outdated
|
|
||
| Originally discussed in [#66](https://github.com/coreos/fedora-coreos-tracker/issues/66). | ||
|
|
||
| - AWS does not require a cloud agent but does require NVME EBS udev rules and a script located at [coreos/init#268](https://github.com/coreos/init/pull/268) |
There was a problem hiding this comment.
I'd say let's leave out the reference to https://github.com/coreos/init/pull/268. so just end this EBS udev rules and a script
the reference to #104 below should be enough
There was a problem hiding this comment.
My editor automatically removed the whitespace so I manually added them back in with another editor. I also addressed the comment ⬆️ . Something is up with my branch but I don't think it will affect the PR or the git history.
mike-nguyen
force-pushed
the
aws
branch
2 times, most recently
from
ea102da
to
f91cce6
Compare
Add design decisions from coreos#66
dustymabe
approved these changes
Jan 9, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add design decisions from #66