Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: add Packet section to cloud agents #130

Closed
wants to merge 1 commit into from

Conversation

dustymabe
Copy link
Member

No description provided.

Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member Author

thanks @arithx - just rebased on top of latest master. will wait for @bgilbert to review before merge

@vielmetti
Copy link

In the design doc, you should link to the Packet doc for the grub console string (which also has to specific 115200 as the bit rate). Also, it's worth noting for arm64 support that the Packet grub console setup for arm64 is ever so slightly different. I'll post the exact Packet docs in a moment.

@dustymabe
Copy link
Member Author

hey @vielmetti, thanks! If you can link us to those docs we will use them when we develop the actual snippets that alter the kernel CLI.

For the design doc I think the point is just that "we'll need some packet specific kernel args".

@dustymabe
Copy link
Member Author

i talked to @bgilbert and he already has a draft adding the packet info to the design doc (oops). I'll close this out in favor of his PR that he'll open shortly.

@bgilbert
Copy link
Contributor

New PR in #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants