design: Add in XFS filesystem decision #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeddeloh
reviewed
Sep 14, 2018
Design.md
Outdated
| ----------------------------------- | ||
| 1 fat32 Boot partition/ESP |
There was a problem hiding this comment.
But I like tabs :( This is even for a TABle.
There was a problem hiding this comment.
oh man haha.. do you really want me to change it back?
There was a problem hiding this comment.
I mean kinda. Not trying to start a holy war, but tabs work nicely for tables.
There was a problem hiding this comment.
I fixed it back to what you had before but no matter what I do I can't make it line up correctly in VIM. I set tabstop to 4 and 8 and neither one of them gives me what I would expect.
|
fixed up the commit message in the first commit |
bgilbert
approved these changes
Sep 14, 2018
|
merging.. really though I would like to know if the columns line up right for you in VIM and what you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.