Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fleetctl stop is slow with large number of units #1343

Closed
iamruinous opened this issue Sep 4, 2015 · 3 comments
Closed

fleetctl stop is slow with large number of units #1343

iamruinous opened this issue Sep 4, 2015 · 3 comments

Comments

@iamruinous
Copy link

Similar to #1340, stop and unload are also incredibly slow when a large number of unit files exist (~2500).

Submitting a pull request in a bit.
iamruinous added a commit to octoblu/fleet that referenced this issue Sep 4, 2015
@iamruinous
fleetctl: optimize stop/unload commands
5a8d47b 
    Use the Unit API instead of Units API to speed up lookups on
    environments with a large number of distinct services.

    Fixes coreos#1343
@wuqixuan
Copy link
Contributor

wuqixuan commented Sep 6, 2015

I totally agree that no need get all unit information.

@ivankennethwang
Copy link

+1

@dongsupark
Copy link
Contributor

As described in #1344 (comment), using Unit() instead of Units() will make the performance rather worse. So I'll close this issue for now.
If anyone has a better idea to improve the performance in a generic manner, please create another PR to do so. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iamruinous @ivankennethwang @dongsupark @wuqixuan