Re-enable check for nil hash in unit state publisher #989

bcwaldon · 2014-10-21T20:14:28Z

There existed checks for nil unit hashes in agent.UnitStatePublisher.publishOne and registry.UnitStateToModel, but given that units could enter the system without populated hashes, the checks were disabled: 11949e0. As of 7a1015a, the hashes should now always be populated, so the corresponding assertions should be reenabled.

If these checks prove to be not useful, they should be removed altogether.

The text was updated successfully, but these errors were encountered:

There existed checks for nil unit hashes in agent.UnitStatePublisher.publishOne and registry.UnitStateToModel, but given that units could enter the system without populated hashes, the checks were disabled: 11949e0. Currently the hashes are now always populated, so the corresponding assertions should be reenabled. Fixes coreos#989

Long time ago there were checks for nil unit hashes in agent.UnitStatePublisher.publishOne and registry.UnitStateToModel, but given that units could enter the system without populated hashes, the checks were disabled: 11949e0 ("agent: publish unit state regardless of hash"). However the hashes are now always populated, so the corresponding assertions should be reenabled. Fixes coreos#989

bcwaldon added the kind/cleanup label Oct 21, 2014

bcwaldon added the help wanted label Dec 18, 2014

dongsupark mentioned this issue Jul 15, 2016

agent: reenable check for nil hash in unit state publisher #1639

Merged

dongsupark closed this as completed in #1639 Jul 22, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable check for nil hash in unit state publisher #989

Re-enable check for nil hash in unit state publisher #989

bcwaldon commented Oct 21, 2014

Re-enable check for nil hash in unit state publisher #989

Re-enable check for nil hash in unit state publisher #989

Comments

bcwaldon commented Oct 21, 2014