Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fleet apparently ignores failed attempt to start unit #998

Closed
bcwaldon opened this issue Oct 22, 2014 · 0 comments · Fixed by #1647
Closed

fleet apparently ignores failed attempt to start unit #998

bcwaldon opened this issue Oct 22, 2014 · 0 comments · Fixed by #1647
Labels
help wanted kind/bug

Comments

@bcwaldon
Copy link
Contributor

Discovered in #974:

Oct 17 04:12:35 infra01.c.secondbit-infra.internal fleetd[562]: ERROR manager.go:80: Failed to trigger systemd unit hgweb.1.service start: Unit code-ssh.1.service failed to load: No such file or directory.
Oct 17 04:12:35 infra01.c.secondbit-infra.internal fleetd[562]: INFO reconcile.go:274: AgentReconciler completed task: type=StartUnit job=hgweb.1.service reason="unit currently loaded but desired state is launched"
@bcwaldon bcwaldon added the bug label Oct 22, 2014
@bcwaldon bcwaldon mentioned this issue Oct 22, 2014
Closed
@bcwaldon bcwaldon mentioned this issue Feb 9, 2015
Closed
@jonboulle jonboulle added kind/bug and removed bug labels Sep 24, 2015
dongsupark pushed a commit to dongsupark/fleet that referenced this issue Jul 22, 2016
agent: check errors from start/stop-ing unit
0829c33 
Now that UnitManager.Trigger{Start,Stop}() could return an error, the
error should be delivered up to mapTaskToFunc(), not to be ignored by
the task manager. Doing that, we can fix a bug in fleet ignoring failed
attempt to start/stop a unit.

Fixes coreos#998
@dongsupark dongsupark mentioned this issue Jul 22, 2016
Merged
@dongsupark dongsupark mentioned this issue Oct 28, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

agent,unit: check errors from start/stop/unload-ing unit endocode/fleet
2 participants
@bcwaldon @jonboulle