Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Switch default fleetctl driver to API #1034

Merged
merged 1 commit into from
Apr 14, 2015
Merged

Conversation

bcwaldon
Copy link
Contributor

Fix #921

@bcwaldon
Copy link
Contributor Author

I don't know what I was thinking before, but you definitely cannot hit the fleet API bound on a unix socket through an SSH tunnel. This means, that a command like this will no longer work: fleetctl --tunnel=127.0.0.1:2222 list-machines. The fleet API can be bound on a TCP socket, but this requires extra work an a non-standard configuration. What can we do about this?

/cc @philips @jonboulle

@jonboulle
Copy link
Contributor

Hrm. Could we somehow provide socket activation on localhost by default and then tunnel through to that?

@bcwaldon
Copy link
Contributor Author

@jonboulle This PR is now rebased on #1035 so we can land the commits that don't actually change the default behavior independently.

We could totally bind fleet.socket on 127.0.0.1:, it just means we will have fleet exposed as a network service, and we'll have to pick the value for that port, two things that we have been trying to avoid.

@bcwaldon bcwaldon force-pushed the driver branch 2 times, most recently from 09d7772 to df75257 Compare November 20, 2014 18:47
@bcwaldon
Copy link
Contributor Author

Updated to preserve behavior of --experimental-api=false on the off-chance that users tried to protect any scripts from this change.

@bcwaldon
Copy link
Contributor Author

bcwaldon commented Dec 1, 2014

Waiting on this until #1039 makes its way out in a release all the way to the CoreOS stable channel

@cnelson
Copy link

cnelson commented Mar 16, 2015

FYI, OpenSSH 6.7 contains support for forwarding unix domain sockets. There's an open request to have it updated from upstream:

coreos/portage-stable#173

@crawford
Copy link
Contributor

LGTM

bcwaldon added a commit that referenced this pull request Apr 14, 2015
Switch default fleetctl driver to API
@bcwaldon bcwaldon merged commit cc31d93 into coreos:master Apr 14, 2015
@bcwaldon bcwaldon deleted the driver branch April 14, 2015 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch default fleetctl transport to HTTP API
4 participants