This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Print "global" in fleetctl list-unit-files #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #1072 |
|
Change LGTM, but I can't remember what we decided re: backwards compatibility? Just have a note in the release notes? |
|
The field is currently "-" for global/unscheduled units, while it's a machine ID & IP address for scheduled units. The argument here is that the field is utterly useless and misleading in the case of a global unit, so I believe it is safe to look at this as fixing a bug rather than simply a backwards-incompatible change. We'll definitely release-note this. |
bcwaldon
added a commit
that referenced
this pull request
Jan 8, 2015
Print "global" in fleetctl list-unit-files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.