This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: set --driver=etcd if --endpoint is etcd-like #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if u, err := url.Parse(eps[0]); err == nil { | ||
| if _, port, err := net.SplitHostPort(u.Host); err == nil { | ||
| if port == "4001" || port == "2379" { | ||
| log.Debugf("Defaulting to --driver=%s as --endpoint appears to be etcd", clientDriverEtcd) |
There was a problem hiding this comment.
How does this look if it's in an anonymous function, returning after failed conditions?
There was a problem hiding this comment.
Or if you wrap the check in a recover() and just assume that the Split, Parse, and SplitHostPort worked.
There was a problem hiding this comment.
visited := make(map[string]bool, 0)
...
if !visited["driver"] && visited["endpoint"] {
if u, err := url.Parse(strings.Split(globalFlags.Endpoint, ",")[0]); err == nil {
if _, port, err := net.SplitHostPort(u.Host); err == nil && (port == "4001" || port == "2379") {
log.Debugf("Defaulting to --driver=%s as --endpoint appears to be etcd", clientDriverEtcd)
globalFlags.ClientDriver = clientDriverEtcd
}
}
}
|
LGTM |
bcwaldon
force-pushed
the
default-driver
branch
from
de175ea
to
22be3e0
Compare
bcwaldon
added a commit
that referenced
this pull request
Apr 29, 2015
fleetctl: set --driver=etcd if --endpoint is etcd-like
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one remaining wart of the switch from --driver=etcd to --driver=API. If someone had been using fleetctl with a custom endpoint like so:
They now all of a sudden get directed to the fleet API rather than etcd. Given that we can tell (based on the port) that the user wants to use etcd, the default of --driver in this case should remain "etcd".