This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
undo quorum=true; wait for unit creation in fleetctl #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4271c4f.
|
|
||
| haserr := false | ||
| for msg := range errchan { | ||
| stderr("Error creating units: %v", msg) |
There was a problem hiding this comment.
"error waiting on unit creation" would be more accurate.
in testing with coretest, fleetd would get spurious errors while creating and then reading back units. it is a race that occurs when a PUT (consistent write to etcd) is immediately followed by a GET (inconsistent read) to the same unit. the real fix for this is to make use of etcd indexes everywhere in fleetd, but unfortunately etcd 0.4.x indexes are broken. as a workaround, we block in fleetctl waiting for acknowledgement of unit creation before proceeding to load/start/etc.
|
@jonboulle looks useful, but not merged yet :( |
|
PTAL |
|
@marineam ping |
|
LGTM |
mischief
added a commit
that referenced
this pull request
Aug 7, 2015
undo quorum=true; wait for unit creation in fleetctl
|
👍 |
|
@mischief multierror is merged. |
|
Can you explain why this was chosen over the use of quorum=true? What are the benefits to this approach? |
|
we maintain compatibility with etcd 0.4.x for now. |
|
iirc quorum=true wasn't a 0.4 limitation, it would just be overly expensive for a large fleet cluster to always use quorum=true for everything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.