This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: optimize status command #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When real 4m24.150s
user 0m0.475s
sys 0m0.155sAnd with this patch: real 0m2.344s
user 0m0.146s
sys 0m0.020s |
|
Whoops, failed the formatter, gimme a sec |
Use the Unit API instead of Units API to speed up lookups on environments with a large number of distinct services. Fixes coreos#1340
royvandewater
force-pushed
the
fleetctl-status-optimization
branch
from
d832f07
to
cd23d91
Compare
|
I think this build failure may not be me, looks like it's the same one that's failing in master. |
|
@royvandewater it is a race condition in the test. it was not your fault. |
|
@royvandewater thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Unit API instead of Units API to speed up lookups on
environments with a large number of distinct services.
Fixes #1340