This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
docs: Added detailed explanation on fleet's Metadata logic #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
force-pushed
the
kayrus/multi_metadata
branch
from
e7f9368
to
7b6fe14
Compare
| [X-Fleet] | ||
| MachineMetadata="region=us-east-1" "diskType=SSD" | ||
| ``` | ||
|
|
||
| This requires an eligible machine to have at least the `region` and `diskType` keys set accordingly. A single key may also be defined multiple times, in which case only one of the conditions needs to be met: | ||
| This requires an eligible machine to have at least the `region` and `diskType` keys set accordingly. I.e. this logic could be represented as follows: |
|
A few small comments, lgtm after that |
kayrus
force-pushed
the
kayrus/multi_metadata
branch
from
7b6fe14
to
9d13386
Compare
|
@jonboulle updated commit and added more details. |
| diskType=SSD AND (region=us-east-1 OR region=us-west-1) | ||
| ``` | ||
|
|
||
| Previous example schedules maximum one unit accross your cluster depending on first met requirement. If you add `Global=true`: |
There was a problem hiding this comment.
The previous example schedules at most one unit across your cluster, depending on the first satisfied requirement.
|
One more comment then looks good to merge. |
And restructured links
kayrus
force-pushed
the
kayrus/multi_metadata
branch
from
9d13386
to
73129c7
Compare
|
@jonboulle fixed |
jonboulle
added a commit
that referenced
this pull request
Feb 10, 2016
docs: Added detailed explanation on fleet's Metadata logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @joshix @robszumski @jonboulle
resolves #1411