Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fleetctl: {load|unload|start|stop} and get unit code cleanups #1433

Merged
merged 8 commits into from
Mar 8, 2016
Merged

fleetctl: {load|unload|start|stop} and get unit code cleanups #1433

merged 8 commits into from
Mar 8, 2016

Commits on Mar 7, 2016

  1. fleetctl: add tryWaitForUnitStates() and getBlockAttempts() 

    * tryWaitForUnitStates() tries to wait for units to reach the desired state.
* getBlockAttempts() gets the correct value of how many attempts to try
		     before giving up on an operation.

These helpers will be used to make the code more consistent and clean.
We do not intended to change any behaviour here.
    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    05948cf View commit details
    Browse the repository at this point in the history

  2. fleetctl: {load|start|stop|unload} use the tryWaitForUnitStates() and… 

    … getBlockAttempts()
    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    7efe868 View commit details
    Browse the repository at this point in the history

  3. fleetctl: move logic to lookup a unit into getUnitFile() and getUnitF… 

    …ileFromTemplate()
    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    9638cf9 View commit details
    Browse the repository at this point in the history

  4. fleetctl: inline getBlockAttempts() in tryWaitForUnitStates() calls

    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    7f7cceb View commit details
    Browse the repository at this point in the history

  5. fleetctl: improve code comment about getUnitFileFromTemplate() 

    Improve code comments about getUnitFileFromTemplate() and kill some
other useless code comments.
    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    2916065 View commit details
    Browse the repository at this point in the history

  6. fleetctl: getBlockAttempts() standarise on negative meaning do not block

    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    ef8bf09 View commit details
    Browse the repository at this point in the history

  7. fleetctl:test: push tests for getBlockAttempts()

    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    9984872 View commit details
    Browse the repository at this point in the history

  8. fleetctl: improve getUnitFile() error handling and add documentation

    Djalal Harouni committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    ae4b987 View commit details
    Browse the repository at this point in the history