-
Notifications
You must be signed in to change notification settings - Fork 302
metrics: added prometheus metrics for fleet #1524
Conversation
@joshix could you review docs? |
LGTM, but defer to @joshix |
LGTM for purpose. Defer on merging due to the godeps update. @kayrus and/or fleet team, PTBF |
Supersedes #1415 |
Nice 😉 |
@jonboulle this PR is ready to be merged. I don't think tests are necessary for this functionality. At least I didn't find any metrics tests in etcd. |
[ Quoting notifications@github.com in "Re: [coreos/fleet] metrics: added p..." ]
Testing this is pretty annoying, would be nice if prometheus would provide some |
LGTM but let's get v0.12.0 done first? |
@jonboulle as discussed all v0.12.0 PRs and Issues have been handled! |
Blocks #1537 |
Thanks all, this one was reviewed and already has lgtm! and it touches lot of parts of the code where other PRs may conflict with it. So merging this one and #1537 will be on top later when it's ready and reviewed. |
@miekg I've rebased your old PR #1415 and updated godeps