Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

metrics: added prometheus metrics for fleet #1524

Merged
merged 3 commits into from
Apr 18, 2016

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 31, 2016

@miekg I've rebased your old PR #1415 and updated godeps

@kayrus kayrus self-assigned this Mar 31, 2016
@kayrus kayrus added this to the v0.13.0 milestone Mar 31, 2016
@kayrus
Copy link
Contributor Author

kayrus commented Mar 31, 2016

@joshix could you review docs?

@robszumski
Copy link
Member

LGTM, but defer to @joshix

@joshix
Copy link
Contributor

joshix commented Apr 1, 2016

LGTM for purpose.

Defer on merging due to the godeps update. @kayrus and/or fleet team, PTBF

@joshix
Copy link
Contributor

joshix commented Apr 1, 2016

Supersedes #1415

@hectorj2f
Copy link
Contributor

Nice 😉

@kayrus
Copy link
Contributor Author

kayrus commented Apr 4, 2016

@jonboulle this PR is ready to be merged. I don't think tests are necessary for this functionality. At least I didn't find any metrics tests in etcd.

@miekg
Copy link
Contributor

miekg commented Apr 4, 2016

[ Quoting notifications@github.com in "Re: [coreos/fleet] metrics: added p..." ]

@jonboulle this PR is ready to be merged. I don't think tests are necessary for this functionality. At least I didn't find any metrics tests in etcd.

Testing this is pretty annoying, would be nice if prometheus would provide some
kind of metrics recorder that would make this easier...

@jonboulle
Copy link
Contributor

LGTM but let's get v0.12.0 done first?

@tixxdz
Copy link
Contributor

tixxdz commented Apr 5, 2016

@jonboulle as discussed all v0.12.0 PRs and Issues have been handled!

@kayrus
Copy link
Contributor Author

kayrus commented Apr 18, 2016

Blocks #1537

@tixxdz
Copy link
Contributor

tixxdz commented Apr 18, 2016

Thanks all, this one was reviewed and already has lgtm! and it touches lot of parts of the code where other PRs may conflict with it. So merging this one and #1537 will be on top later when it's ready and reviewed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants