This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
[WIP] ssh: workaround to not block Stdin from returning corrrectly #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assign session.stdin using StdinPipe() to avoid cases of ssh connetions being blocked on user input. WIP. Reported-by: kayrus <kay.diam@gmail.com> maybe partly resolves coreos#1499
dongsupark
force-pushed
the
master
branch
3 times, most recently
from
23d4b13
to
6fb1256
Compare
dongsupark
force-pushed
the
master
branch
2 times, most recently
from
54409ab
to
a1a21b8
Compare
|
After traversing a long rabbit hole, I realized that it would not be easy at all to fix this issue. Even with goroutines & wrappers around stdin, io.Copy still remained being blocked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign
session.stdinusingStdinPipe()to avoid cases of ssh connetions being blocked on user input.WIP, do not merge. Not tested.
Reported-by @kayrus
maybe partly resolves #1499