This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fix(fleetctl): write directly os.Stdout instead of tabwriter #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcwaldon
commented
Jun 7, 2014
bcwaldon
commented
- Using tabwriter here is unnecessary, and was probably a mistake from the beginning
- This removes concurrent access to tabwriter.Writer, which is apparently not threadsafe
|
lgtm |
bcwaldon
added a commit
that referenced
this pull request
Jun 11, 2014
fix(fleetctl): write directly os.Stdout instead of tabwriter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.