chore(*): rename Batch to Oneshot #533
Conversation
| // completion, not be migrated around the cluster. This is determined by | ||
| // whether the unit file associated with the Job is a Service of type "oneshot". | ||
| func (j *Job) IsBatch() bool { | ||
| func (j *Job) IsOneshot() bool { | ||
| s, ok := j.Unit.Contents["Service"] |
There was a problem hiding this comment.
Is it valid for a unit to have a .socket extension yet define a [Service] section?
There was a problem hiding this comment.
Nope:
Jun 10 01:13:45 core-01 systemd[1]: [/etc/systemd/system/foo.socket:1] Unknown section 'Service'. Ignoring.
There was a problem hiding this comment.
But in our case, we will not ignore the Service section in a non-service unit. That feels wrong.
There was a problem hiding this comment.
I am not sure making this particular function handle all edge cases like
that is the right answer. This sounds more like the task of a proper unit
linter (used at submission time, ideally) as we've talked about previously.
On Jun 10, 2014 6:44 AM, "Brian Waldon" notifications@github.com wrote:
In job/job.go:
// completion, not be migrated around the cluster. This is determined by
// whether the unit file associated with the Job is a Service of type "oneshot".
-func (j *Job) IsBatch() bool {
+func (j *Job) IsOneshot() bool {
s, ok := j.Unit.Contents["Service"]But in our case, we will not ignore the Service section in a non-service
unit. That feels wrong.—
Reply to this email directly or view it on GitHub
https://github.com/coreos/fleet/pull/533/files#r13593569.
There was a problem hiding this comment.
Sure, I'm not suggesting this function has to solve the problem. I'd like to address this problem before oneshot support ships, though.
|
lgtm |
chore(*): rename Batch to Oneshot
No description provided.