This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
agent: stop units in goroutine during init #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why this wasn't the case previously? |
|
@jonboulle Probably since the agent could be running some ghost units that could conflict with other units being scheduled there. I think this PR is the lesser of two evils, since we really can't allow user jobs to DoS a fleet node. |
|
OK, maybe we can revisit once go-systemd has a better way of handling things asynchronously |
|
LGTM |
bcwaldon
added a commit
that referenced
this pull request
Jul 8, 2014
agent: stop units in goroutine during init
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #624