This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Get rid of glog #802
Merged
Get rid of glog #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,11 +47,6 @@ func (c *Config) Metadata() map[string]string { | |||
| func UpdateLoggingFlagsFromConfig(flagset *flag.FlagSet, conf *Config) { | |||
There was a problem hiding this comment.
You can kill this function now right?
There was a problem hiding this comment.
I thought I did...
|
flog?!? what's wrong with just "log"? |
|
@jonboulle I guess it could be "log", but where's the fun in that? |
|
We don't get paid to have fun. |
|
Okay :( |
|
Lose the fun, then LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glog does too much and has caused too much heartache. A new
flogpackage is a drop-in replacement for what fleet needs from glog.