This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Rename fleet binary to fleetd #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just about to do this.. |
|
carry on |
|
@bcwaldon I think this is everything on the fleet repo side, but obvs we need to do things in coreos-overlay next time we bump the release |
| echo "Building fleet..." | ||
| go install ${REPO_PATH} | ||
| echo "Building fleetd..." | ||
| go install ${REPO_PATH}/fleetd | ||
| else | ||
| echo "Not on Linux - skipping fleet build" |
jonboulle
force-pushed
the
fleetd
branch
2 times, most recently
from
c8d4496
to
645368d
Compare
|
Wow. I never thought I'd see the day that ./fleet.go moved. |
|
And yes, coreos-overlay next time we bump. We may want to leave a symlink around from fleet -> fleetd for a release or two just so we can warn people |
|
@jonboulle docs need updating |
|
I think that's it.. |
|
squish n ship |
|
👍 |
jonboulle
added a commit
that referenced
this pull request
Aug 22, 2014
Rename fleet binary to fleetd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently generate two binaries:
fleetandfleetctl. It is common to executefleetby accident when intending to usefleetctl. We should renamefleettofleetdto make it clearer that it is a daemon and to force people to make an explicit choice when tab-completing.