This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
API should validate unit names #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open to suggestions about where some of these pieces should sit in the codebase - dedicated constants/requirements file perhaps? |
| @@ -103,12 +104,58 @@ func (ur *unitsResource) set(rw http.ResponseWriter, req *http.Request, item str | |||
| ur.update(rw, su.Name, su.DesiredState) | |||
| } | |||
|
|
|||
| const unitNameMax = 256 | |||
|
Thanks for digging into this. Two style nits then LGTM |
|
We may want to revisit to rearrange some of this stuff (e.g. this logic should be in the same place as |
jonboulle
force-pushed
the
validate_unit_names
branch
from
a304a7c
to
a64c9ca
Compare
jonboulle
added a commit
that referenced
this pull request
Sep 9, 2014
API should validate unit names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd is opinionated about what constitutes a valid unit name. fleet should validate this at unit-creation time to prevent issues like #845 and #793.