Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

call "daemon-reload" only when necessary #944

Merged
merged 2 commits into from
Oct 4, 2014
Merged

call "daemon-reload" only when necessary #944

merged 2 commits into from
Oct 4, 2014

Conversation

jonboulle
Copy link
Contributor

Turns out invoking daemon-reload on systemd is really expensive. Work out how we can minimize calls to what is absolutely necessary.

@jonboulle jonboulle added this to the v0.9.0 milestone Oct 4, 2014
@jonboulle
Copy link
Contributor Author

@bcwaldon this should be a fairly uncontroversial change...

@jonboulle
Copy link
Contributor Author

before

time fleetctl start foo@{1..100}.service
...
real    1m19.258s
user    0m6.995s
sys 0m5.928s

after

time fleetctl start foo@{1..100}.service
...
real    0m6.812s
user    0m0.595s
sys 0m0.476s

@jonboulle
Copy link
Contributor Author

previously, previously (no context on the latter :-()

@bcwaldon
Copy link
Contributor

bcwaldon commented Oct 4, 2014

LGTM

jonboulle added a commit that referenced this pull request Oct 4, 2014
@jonboulle
Merge pull request #944 from jonboulle/944_daemon_reload
d2fcfe0 
call "daemon-reload" only when necessary
@jonboulle jonboulle merged commit d2fcfe0 into coreos:master Oct 4, 2014
@jonboulle jonboulle deleted the 944_daemon_reload branch October 4, 2014 01:07
@bcwaldon bcwaldon modified the milestones: v0.8.4, v0.9.0 Oct 4, 2014
@bcwaldon bcwaldon mentioned this pull request Oct 20, 2014
Closed
@bcwaldon bcwaldon modified the milestones: v0.9.0, v0.8.4 Oct 20, 2014
@akaspin akaspin mentioned this pull request Feb 26, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonboulle @bcwaldon