oidc: have NewRemoteKeySet return a concrete type #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return a concrete type so RemoteKeySet can export any additional configuration later. This is a breaking change to the API, so a good candidate for the v3 branch. See "Accept interfaces, return structs"
This was referenced Jan 7, 2021
1 task
kfaseela
added a commit
to Nordix/istio
that referenced
this pull request
Oct 22, 2021
An internal 3pp scan for istio reports that a newer version of oidc is available. Trying an upgrade attempt. As per the documentation, there is an api incompatibility between v2 and v3, however analysing the code, it seems to be handled correctly. https://github.com/coreos/go-oidc#updates-from-v2-to-v3 coreos/go-oidc#262 Signed-off-by: Faseela K <faseela.k@est.tech>
7 tasks
istio-testing
pushed a commit
to istio/istio
that referenced
this pull request
Oct 25, 2021
An internal 3pp scan for istio reports that a newer version of oidc is available. Trying an upgrade attempt. As per the documentation, there is an api incompatibility between v2 and v3, however analysing the code, it seems to be handled correctly. https://github.com/coreos/go-oidc#updates-from-v2-to-v3 coreos/go-oidc#262 Signed-off-by: Faseela K <faseela.k@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a concrete type so RemoteKeySet can export any additional
configuration later. This is a breaking change to the API, so a good
candidate for the v3 branch.
See "Accept interfaces, return structs"
Updates #214
Updates #232