Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdjournal: add ability to rewind JournalReader #160

Merged
merged 2 commits into from
May 20, 2016
Merged

sdjournal: add ability to rewind JournalReader #160

merged 2 commits into from
May 20, 2016

Conversation

jonboulle
Copy link
Contributor

Simple wrapper around sd_journal_seek_head

@jonboulle jonboulle mentioned this pull request May 20, 2016
Merged
@iaguis
Copy link
Contributor

iaguis commented May 20, 2016

To do https://github.com/coreos/rkt/pull/2662/files/4c8103a493c21591f564d4ffa88e9c43d61a5358#r63889264 we need to expose this in JournalReader too.

@jonboulle jonboulle changed the title sdjournal: add SeekHead method sdjournal: add ability to rewind JournalReader May 20, 2016
@jonboulle
Copy link
Contributor Author

up day ted

@iaguis
Copy link
Contributor

iaguis commented May 20, 2016

@jonboulle
Copy link
Contributor Author

no

On Fri, May 20, 2016 at 11:54 AM, Iago López Galeiras <
notifications@github.com> wrote:

https://camo.githubusercontent.com/6fc7934842a80e654de0e222ede2eeffead90f6b/687474703a2f2f692e7974696d672e636f6d2f76692f45777261654f33456c48492f6d617872657364656661756c742e6a7067

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#160 (comment)

@iaguis
Copy link
Contributor

iaguis commented May 20, 2016 

iaguis@locke-xps13: ~/work/coreos/go/src/github.com/coreos/go-systemd/sdjournal [(de7d752...)] 
> go test -v .
# github.com/coreos/go-systemd/sdjournal
could not determine kind of name for C.my_sd_journal_seek_head
FAIL    github.com/coreos/go-systemd/sdjournal [build failed]

@jonboulle
Copy link
Contributor Author

<- idiot

@iaguis
Copy link
Contributor

iaguis commented May 20, 2016

cgo -> hard

@jonboulle
sdjournal: add SeekHead method
48fe794 
Simple wrapper around `sd_journal_seek_head`
@jonboulle
sdjournal: add Rewind method to JournalReader
0f21494 
This allows users of the JournalReader to rewind to the beginning of the
Journal.

Also add a missing docstring to JournalReader.Close
@jonboulle
Copy link
Contributor Author

// char *
// my_boilerplate()
// {
// char * boiler_plate;
// boiler_plate = "dumb";
// return boiler_plate;
// }

@iaguis
Copy link
Contributor

iaguis commented May 20, 2016

lgtm

@iaguis iaguis merged commit 1d9051f into coreos:master May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonboulle @iaguis