import1: Implement importd methods #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @lucab, this PR is ready for review. |
lucab
reviewed
Jun 17, 2019
| return c, nil | ||
| } | ||
|
|
||
| func (c *Conn) initConnection() error { |
There was a problem hiding this comment.
Note to self: this is a connection helper duplicated in a few places, we should later move it to a common sub-package under internal.
lucab
reviewed
Jun 19, 2019
|
Two minor things left, looks ready otherwise. @Xuanwo feel free to squash into a single commit. |
systemd-importd service is used to import, export and download additional system images, for running them as local containers using tools such as systemd-nspawn. This commit allow users to import/export/pull images via systemd-importd.
|
This PR is ready for merge now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-importd service is used to import, export and download
additional system images, for running them as local containers
using tools such as systemd-nspawn.
This PR allows users to import/export/pull images via
systemd-importd.
Fix #232