-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
journal: close unix socket after successful probe #367
journal: close unix socket after successful probe #367
Conversation
Good catch, and thanks for the separate bug report too! It is my understanding that the garbage collector would eventually take care of the stale socket, and that most consumers would do the probe only once upfront and then cache the result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments on spurious new lines. When fixing those, can you please squash everything into a single final commit?
Head branch was pushed to by a user without write access
2f17ced
to
6835f56
Compare
This is done to ensure unix sockets aren't left dangling after each Enabled() call, which can lead to eventual process resource exhaustion. Fixes coreos#366.
6835f56
to
68a12a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done to ensure unix sockets aren't left dangling after each Enabled() call, which
can lead to eventual process resource exhaustion. Fixes #366.