dbus: add support for querying unit by PID #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to get the unit name by PID. Similar to `systemctl status {pid}`
lucab
reviewed
Dec 13, 2021
dbus/methods.go
Outdated
|
|
||
| // GetUnitByPIDContext returns the unit name for a given PID. The PID must refer | ||
| // to an existing system process | ||
| func (c *Conn) GetUnitByPIDContext(ctx context.Context, pid uint32) (string, error) { |
There was a problem hiding this comment.
We can drop the Context suffix from here (it's an historical artifact added for method that started their existence before context was a thing).
I agree getting the unit name is probably the most common case, but the object path could be useful too in some case.
I'd suggest having a plain GetUnitByPID that directly returns the object path, and an additional GetUnitNameByPID which internally does some translation. No need for a separate getUnitInternal helper, that logic can be folded directly into the latter.
There was a problem hiding this comment.
Works for me, should be addressed
|
Welcome and thanks for the PR! Overall it looks nice, I've left some minor suggestions in review. |
PID-based queries can now return either a name or a path
lucab
changed the title
lucab
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the functionality of the
GetUnitByPIDmethod and could be useful in situations where you're trying to find which unit owns a given process.I chose to convert from
dbus.ObjectPathto astring(the name of the unit) since almost nothing in this library accepts andbus.ObjectPathas an input, and the methods for converting back and forth are private and not available to users. The current output format could then be passed intoListUnitsByNamesin order to get further information.