Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login1: add NewWithConnection and RebootWithContext methods #390

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

login1: add NewWithConnection and RebootWithContext methods #390

wants to merge 4 commits into from

Commits on Jan 10, 2022

  1. Bump minimum Go version to 1.13 

    1.12 is now EOL for almost 2 years: https://endoflife.date/go.

As a reference, supported Ubuntu versions use either 1.10 or 1.13:
https://packages.ubuntu.com/search?keywords=golang-go

So I think this bump is reasonable.

This is done to get access to stdlib methods like errors.Is and
formatting statement %w, which is de facto standard for handling errors
nowadays.

Closes coreos#391

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
    @invidian
    invidian committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    4da2df9 View commit details
    Browse the repository at this point in the history

  2. login1: Use blackbox testing 

    This is a desired way of testing to avoid creating fragile test suites
and be able to refactor code without touching tests.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
    @invidian
    invidian committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c3a73b1 View commit details
    Browse the repository at this point in the history

  3. login1: Add NewWithConnection method 

    This method allows passing existing D-Bus connection, which allows to
re-use connection between clients and to mock D-Bus connection for
testing purposes.

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
    @invidian
    invidian committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    9a42b6b View commit details
    Browse the repository at this point in the history

  4. login1: Add RebootWithContext method 

    Existing Reboot() method does not allow using context not inspecting
D-Bus call errors, which makes it difficult to debug and use.

This commit adds new RebootWithContext() method which addresses those
shortcomings.

Closes coreos#387

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
    @invidian
    invidian committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1a186bc View commit details
    Browse the repository at this point in the history