Remove OnFailure= from targets, put in services #188
Conversation
In systemd v245, which is in f32, the `OnFailure=` directive in target units stopped working. This seems to be by design though: systemd/systemd#14142 If target units were never meant to handle this, this might be why we've had issues like boot loops on failure in the past (see #115). Anyway, let's just pepper our services with the directive instead.
|
I asked if there's a cleaner way to do this now: systemd/systemd#14142 (comment) |
|
OK, I think we should really get this in. Right now on f32 FCOS, Ignition failures do not cause a failed boot. (I thought we had a test for that, but I guess not.) |
|
I think this is safe but it's worth asking the question: If this change were to make its way into an f31 based FCOS (or another distro at the older version of systemd) is it still safe to make? |
Yes, this is a backwards compatible change. I've just tested this on top of current FCOS stable (which is still on f31) and sanity-checked that it works fine in both the failure and success path. |
In systemd v245, which is in f32, the
OnFailure=directive in targetunits stopped working. This seems to be by design though:
systemd/systemd#14142
If target units were never meant to handle this, this might be why we've
had issues like boot loops on failure in the past (see #115).
Anyway, let's just pepper our services with the directive instead.