stages/disks: get filesystem info via device alias #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to use the device alias when querying filesystem info, leading to potential races with udev deleting and recreating symlinks if the device node is specified via a /dev/disk link. https://bugzilla.redhat.com/show_bug.cgi?id=1812233
cgwalters
approved these changes
Jul 24, 2020
| @@ -91,18 +91,19 @@ func (s stage) createFilesystem(fs types.Filesystem) error { | |||
| if fs.Format == nil { | |||
| return nil | |||
| } | |||
| devAlias := util.DeviceAlias(string(fs.Device)) | |||
There was a problem hiding this comment.
I believe you this fixes it but honestly I hadn't looked at device_alias.go before...would it be fair to say this is basically creating a "snapshot" of the device symlinks at a point in time so they're stable? (OK yes, a quick blame takes me to 521b947 - though that would be a good comment at the top of the file)
There was a problem hiding this comment.
Yup, it's a recurring pattern throughout the disks stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to use the device alias when querying filesystem info, leading to potential races with udev deleting and recreating symlinks if the device node is specified via a
/dev/disklink.https://bugzilla.redhat.com/show_bug.cgi?id=1812233