Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

providers/nutanix: Add Nutanix platform #1284

Merged
merged 5 commits into from
Nov 24, 2021
Merged

providers/nutanix: Add Nutanix platform #1284

merged 5 commits into from
Nov 24, 2021

Conversation

sohankunkerkar
Copy link
Member

xref: coreos/fedora-coreos-tracker#1007
Tested this change on Nutanix AHV and it seems to be working fine.
nutanix-vm

$  ssh core@192.168.2.156
The authenticity of host '192.168.2.156 (192.168.2.156)' can't be established.
ED25519 key fingerprint is SHA256:xxxxxxxx.
This key is not known by any other names
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
Warning: Permanently added '192.168.2.156' (ED25519) to the list of known hosts.
Fedora CoreOS 35.20211116.dev.0
Tracker: https://github.com/coreos/fedora-coreos-tracker
Discuss: https://discussion.fedoraproject.org/c/server/coreos/

[core@fcos-ignition-f35-minimal ~]$ 
[core@fcos-ignition-f35-minimal ~]$ cat /proc/cmdline 
BOOT_IMAGE=(hd0,gpt3)/ostree/fedora-coreos-b14045b72b16211ba96b27fd2a0231abfaeff6e287541c781c2a1ffdb25769e9/vmlinuz-5.14.17-301.fc35.x86_64 mitigations=auto,nosmt console=tty0 console=ttyS0,115200n8 ignition.firstboot ostree=/ostree/boot.1/fedora-coreos/b14045b72b16211ba96b27fd2a0231abfaeff6e287541c781c2a1ffdb25769e9/0 ignition.platform.id=nutanix

@sohankunkerkar sohankunkerkar changed the title Add nutanix platform providers/nutanix: Add nutanix platform Nov 16, 2021
@sohankunkerkar sohankunkerkar changed the title providers/nutanix: Add nutanix platform providers/nutanix: Add Nutanix platform Nov 16, 2021
jlebon
jlebon approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but LGTM overall.

docs/supported-platforms.md Show resolved Hide resolved
internal/providers/nutanix/nutanix.go Outdated Show resolved Hide resolved
internal/providers/nutanix/nutanix.go Outdated Show resolved Hide resolved
internal/providers/nutanix/nutanix.go Show resolved Hide resolved
sohankunkerkar added a commit to sohankunkerkar/coreos-assembler that referenced this pull request Nov 19, 2021
@sohankunkerkar
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
39a38c8 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
sohankunkerkar added a commit to sohankunkerkar/coreos-assembler that referenced this pull request Nov 19, 2021
@sohankunkerkar
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
da5e80a 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
sohankunkerkar added a commit to sohankunkerkar/coreos-assembler that referenced this pull request Nov 19, 2021
@sohankunkerkar
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
4328f52 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
sohankunkerkar added a commit to sohankunkerkar/coreos-assembler that referenced this pull request Nov 19, 2021
@sohankunkerkar
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
20bcb27 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
@sohankunkerkar sohankunkerkar mentioned this pull request Nov 19, 2021
Merged
sohankunkerkar added a commit to sohankunkerkar/coreos-assembler that referenced this pull request Nov 22, 2021
@sohankunkerkar
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
b5e7a0a 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
sohankunkerkar added a commit to sohankunkerkar/coreos-assembler that referenced this pull request Nov 22, 2021
@sohankunkerkar
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
45f8dee 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
jlebon
jlebon reviewed Nov 22, 2021
View reviewed changes
internal/providers/cloudstack/cloudstack.go Outdated Show resolved Hide resolved
internal/providers/util/partition.go Outdated Show resolved Hide resolved
internal/providers/nutanix/nutanix.go Outdated Show resolved Hide resolved
jlebon
jlebon reviewed Nov 23, 2021
View reviewed changes
internal/providers/powervs/powervs.go Outdated Show resolved Hide resolved
internal/providers/nutanix/nutanix.go Outdated Show resolved Hide resolved
internal/util/partition.go Outdated Show resolved Hide resolved
jlebon
jlebon approved these changes Nov 23, 2021
View reviewed changes
internal/util/umount.go Show resolved Hide resolved
@bgilbert
Copy link
Contributor

Superficial LGTM.

jlebon pushed a commit to coreos/coreos-assembler that referenced this pull request Nov 24, 2021
@sohankunkerkar @jlebon
src/*: add cmd-buildextend-nutanix to prepare a nutanix raw image
50d9c23 
Related to coreos/fedora-coreos-tracker#1007
Build a raw image with the Ignition provider set to nutanix
to correspond with coreos/ignition#1284
@sohankunkerkar sohankunkerkar merged commit b456e4d into coreos:main Nov 24, 2021
@sohankunkerkar sohankunkerkar deleted the add-nutanix-platform branch November 24, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert bgilbert left review comments

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohankunkerkar @bgilbert @jlebon