Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filesystem.go: add warning when path matches device #1412

Merged
merged 2 commits into from
Oct 25, 2022
Merged

filesystem.go: add warning when path matches device #1412

merged 2 commits into from
Oct 25, 2022

Commits on Oct 25, 2022

  1. storage.go: add filesystems validation warnings 

    Fixes coreos#1397, a common configuration error is to create a filesystem over
a whole-disk device rather than a partition. Add a warning for a
filesystem device matching the disk device.

Additionally, another configuration error was identified for a way to
recreate the filesystem on every provision, while the configuration to
do so is valid, it might be done unitionally. Add a warning when
wipeTable is true but wipeFilesystem is false.
    @prestist
    prestist committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    a8d088f View commit details
    Browse the repository at this point in the history

  2. storage.go: refactor validate() 

    Separate validate() into more granular subfunctions which describe the unit
of work they are performing to improve readability and testability.
    @prestist
    prestist committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b099378 View commit details
    Browse the repository at this point in the history