-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/types: prevent files/links/dirs from conflicting with systemd units or dropins #1456
Conversation
This validation may need to be updated to include the fix for #1457 whenever that is implemented. |
32f6f08
to
9a68de1
Compare
I updated this PR to add validation to versions of Ignition in |
9a68de1
to
9fd9d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These errors in config_test.go are what I saw locally. I'll add back in the other lines explicitly setting these other members to be empty. https://github.com/coreos/ignition/actions/runs/3191845930/jobs/5208635971#step:5:30
ffd0196
to
66ed4ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small fixes, but this generally looks good. 👍
Please don't include substantive changes and a rebase in the same force-push; it makes the interdiff hard to read. We generally try to rebase, force-push, and then make substantive changes (or the other way around).
66ed4ce
to
24d1b10
Compare
I didnt know think about how it would affect the PR in that way. Thanks for the feedback! |
24d1b10
to
4f3f823
Compare
4f3f823
to
a3f14e8
Compare
…ystemd units and dropins
a3f14e8
to
2f63faa
Compare
Fixes Ignition#881.
Users can specify files/links/dirs within
/etc/systemd/system
that would conflict with systemd units or dropin files at the same location. Add validation to prevent this configuration conflict.See machine-config-operator#1203 for the decision to add this validation to Ignition.