Luks blackbox tests #1685
Merged
Luks blackbox tests #1685
+192
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestist
force-pushed
the
luks-blackbox-tests
branch
2 times, most recently
from
0e5c593
to
efb11c6
Compare
prestist
force-pushed
the
luks-blackbox-tests
branch
2 times, most recently
from
7e2ffb6
to
5489926
Compare
prestist
force-pushed
the
luks-blackbox-tests
branch
4 times, most recently
from
dfa7816
to
1a9aee7
Compare
jlebon
reviewed
Sep 11, 2023
prestist
force-pushed
the
luks-blackbox-tests
branch
from
1a9aee7
to
b55d5f2
Compare
prestist
commented
Apr 30, 2024
prestist
force-pushed
the
luks-blackbox-tests
branch
from
e84adda
to
6ea7fac
Compare
jlebon
reviewed
May 22, 2024
prestist
force-pushed
the
luks-blackbox-tests
branch
2 times, most recently
from
71395ca
to
0069a26
Compare
|
Added issue for Clevis binding validation; feel free to add more detail. #1877 |
prestist
commented
May 29, 2024
jlebon
reviewed
Jun 3, 2024
prestist
force-pushed
the
luks-blackbox-tests
branch
from
0069a26
to
0752a7d
Compare
jlebon
reviewed
Jun 5, 2024
tests/blackbox_test.go
Outdated
| @@ -150,6 +151,7 @@ func outer(t *testing.T, test types.Test, negativeTests bool) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
tests/negative/luks/creation.go
Outdated
| register.Register(register.NegativeTest, LuksOnNonExtDevice()) | ||
| } | ||
|
|
||
| func LuksOnNonExtDevice() types.Test { |
There was a problem hiding this comment.
Can you add a docstring above this line explaining what this negative test is checking?
There was a problem hiding this comment.
I can add more detail if necessary I fixed some naming and I think that does a lot.
tests/positive/luks/creation.go
Outdated
Comment on lines
39
to
52
| "ignition": { "version": "$version" }, | ||
| "storage": { | ||
| "disks": [ | ||
| { | ||
| "device": "$DEVICE", | ||
| "partitions": [ | ||
| { | ||
| "label": "luks-device", | ||
| "sizeMiB": 0, | ||
| "startMiB": 0 | ||
| } | ||
| ], | ||
| "wipe_table": true | ||
| } | ||
| ], | ||
| "luks": [ | ||
| { | ||
| "device": "$DEVICE", | ||
| "name": "$UUID", | ||
| "keyFile": { | ||
| "compression": "", | ||
| "source": "data:,REPLACE-THIS-WITH-YOUR-KEY-MATERIAL" | ||
| }, | ||
| "wipe_volume": true | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
This test is creating a partition on $DEVICE, but then creating a LUKS device on the disk instead of the partition, nuking the freshly created partition table. Is that intended?
Similarly below.
There was a problem hiding this comment.
Yeah; Some how doing it this way made the tests pass. I am not sure why but I was using 'wipe_volume' which is bu. not ign. and this config got away with it. I noticed that just now and dropped the partitions and switched to the correct .ign field.
prestist
force-pushed
the
luks-blackbox-tests
branch
2 times, most recently
from
0aa6c4c
to
61e9cf5
Compare
jlebon
reviewed
Jun 12, 2024
Until now, the blackbox tests would not correctly cleanup after running a test with a luks device. Now Luks devices can be tested using blackbox test framework.
prestist
force-pushed
the
luks-blackbox-tests
branch
from
61e9cf5
to
6278609
Compare
jlebon
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1554