akamai: fix base64 decoding #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
prestist
approved these changes
Jun 25, 2024
trailing \x00 character was making Ignition to fail parsing the config. It is not always the case, that is why we did not catch it earlier: when there is no padding in the base64 payload, everything was working. https://pkg.go.dev/encoding/base64#Encoding.Decode Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/akamai
branch
from
c39e780
to
4840056
Compare
|
Thank you @tormath1, Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trailing \x00 character was making Ignition to fail parsing the config. It is not always the case, that is why we did not catch it earlier: when there is no padding in the base64 payload, everything was working.
https://pkg.go.dev/encoding/base64#Encoding.Decode
cc @nesv
(sorry for the screenshot but it's not easy to copy-paste logs from emergency shell)
EDIT: Successfully tested on Flatcar test build with previously failing configuration.