Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: remove support for oracle oci platform #537

Merged
merged 1 commit into from
Apr 26, 2018
Merged

internal: remove support for oracle oci platform #537

merged 1 commit into from
Apr 26, 2018
+0 −64

Conversation

cgonyeo
Copy link
Contributor

@cgonyeo cgonyeo commented Apr 26, 2018

Container Linux will not be supporting the oracle oci platform, so
remove support for it from Ignition.

internal: remove support for oracle oci platform
a9e4b12 
Container Linux will not be supporting the oracle oci platform, so
remove support for it from Ignition.
bgilbert
bgilbert approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arithx
arithx approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Blackbox test failure unrelated

@cgonyeo
Copy link
Contributor Author

cgonyeo commented Apr 26, 2018

retest this please

1 similar comment
@cgonyeo
Copy link
Contributor Author

cgonyeo commented Apr 26, 2018

retest this please

@cgonyeo cgonyeo merged commit 9796484 into coreos:master Apr 26, 2018
@cgonyeo cgonyeo deleted the remove-oci branch April 26, 2018 22:01
@redbaron
Copy link

Is there any public communication regarding this decision?

@bgilbert
Copy link
Contributor

@redbaron There isn't. This change is part of a broader set of changes to drop Oracle OCI support code from Container Linux as a whole. While Container Linux images for Oracle OCI have previously been uploaded to the public release buckets (example), they've never been published on the Oracle OCI cloud nor have they been documented, so we don't expect these changes to break any existing environments.

If other Linux distributions that use Ignition want to support Oracle OCI, we can revert this change specifically in Ignition and in coreos-metadata.

@redbaron
Copy link

we might need to go to oracle cloud in near future, it is sad not to have CL as an option to choose from

@bgilbert bgilbert mentioned this pull request Mar 10, 2020
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithx arithx arithx approved these changes

@bgilbert bgilbert bgilbert approved these changes

@ajeddeloh ajeddeloh Awaiting requested review from ajeddeloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgonyeo @redbaron @bgilbert @arithx