Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fetch stage #859

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Add a fetch stage #859

merged 1 commit into from
Sep 24, 2019

Conversation

cgwalters
Copy link
Member

This stage just triggers the internal code which fetches the
config and writes /run/ignition.json; from there it'd be picked
up by later stages the way it was implicitly before.

This is prep for adding support for redeploying the rootfs for
Fedora CoreOS; we need to have a separate process determine
whether the rootfs is being replaced, and if so do a save/restore
across ignition-disks.service.

See: coreos/ignition-dracut#107

@cgwalters
Copy link
Member Author

Used by: coreos/ignition-dracut#110

Copy link
Contributor

@ajeddeloh ajeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from two nits. This will also make it more clear if failures were from fetching the config or actually running the disks stage.

internal/exec/stages/fetch/fetch.go Show resolved Hide resolved
internal/exec/stages/fetch/fetch.go Outdated Show resolved Hide resolved
This stage just triggers the internal code which fetches the
config and writes `/run/ignition.json`; from there it'd be picked
up by later stages the way it was implicitly before.

This is prep for adding support for redeploying the rootfs for
Fedora CoreOS; we need to have a separate process determine
whether the rootfs is being replaced, and if so do a save/restore
across `ignition-disks.service`.

See: coreos/ignition-dracut#107
@cgwalters
Copy link
Member Author

Updated to address nits!

@cgwalters cgwalters merged commit 61b7db7 into coreos:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants