[spec2x] Add a fetch stage
#863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per openshift/enhancements#15 the plan is to change RHCOS to come LUKS by default short term, and not do ignition-rootfs moves. However, we need a way to configure the LUKS inside the initramfs to pass that config to a custom dracut module. In combination with the fact that Ignition ignores unknown keys, this split out |
|
Imports need fixing to not import v2 stuff, otherwise lgtm |
cgwalters
force-pushed
the
spec2x-fetch
branch
from
38c572e
to
fae7992
Compare
|
Gofmt failed. |
This stage just triggers the internal code which fetches the config and writes `/run/ignition.json`; from there it'd be picked up by later stages the way it was implicitly before. This is prep for adding support for redeploying the rootfs for Fedora CoreOS; we need to have a separate process determine whether the rootfs is being replaced, and if so do a save/restore across `ignition-disks.service`. See: coreos/ignition-dracut#107 (cherry picked from commit 8926f0f)
cgwalters
force-pushed
the
spec2x-fetch
branch
from
fae7992
to
8e5968f
Compare
|
Made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stage just triggers the internal code which fetches the
config and writes
/run/ignition.json; from there it'd be pickedup by later stages the way it was implicitly before.
This is prep for adding support for redeploying the rootfs for
Fedora CoreOS; we need to have a separate process determine
whether the rootfs is being replaced, and if so do a save/restore
across
ignition-disks.service.See: coreos/ignition-dracut#107
(cherry picked from commit 8926f0f)