blkid: Explicitly use C int variable for numParts #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an issue I encountered while testing partition creation on s390x, where the number of partitions returned by numParts was a bogus number. At first I thought it was an endianness issue with blkid, but turned out that the C compiler's int variable size and the Go compiler's int variable sizes are different (on s390x at least) which caused this bug. The fix is to make numParts a C int variable to be consistent with what is returned by blkid
|
Can one of the admins verify this patch? |
cgwalters
approved these changes
Mar 4, 2020
yes...that must be it..i don't see this anywhere else |
ashcrow
approved these changes
Mar 4, 2020
|
/lgtm |
Prashanth684
added a commit
to Prashanth684/coreos-assembler
that referenced
this pull request
Mar 4, 2020
…tions test As with mounting disks, the same change is needed for mounting partitions for s390x. A little delay in pushing this because of this issue in ignition: coreos/ignition#930 which is now fixed
openshift-merge-robot
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 5, 2020
…tions test As with mounting disks, the same change is needed for mounting partitions for s390x. A little delay in pushing this because of this issue in ignition: coreos/ignition#930 which is now fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue I encountered while testing partition creation on s390x, where the
number of partitions returned by numParts was a bogus number. At first I thought it was
an endianness issue with blkid, but turned out that the C compiler's int variable size and
the Go compiler's int variable sizes are different (on s390x at least) which caused this bug.
The fix is to make numParts a C int variable to be consistent with what is returned by blkid