providers/file: Return ErrNoProvider on ENOENT #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file doesn't exist, return the internal error which means "not found" as opposed to a parse error. Prep for further changes around detecting whether an Ignition config is provided.
|
(Not tested locally yet) |
|
I ended up not using this and did something more elaborate in #948 - I think this still makes sense to merge, but it's not a strong feeling. |
|
The |
|
Thoughts on closing this in favour of #956? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file doesn't exist, return the internal error which
means "not found" as opposed to a parse error.
Prep for further changes around detecting whether an Ignition
config is provided.