Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: unify resource fetching type #953

Merged
merged 2 commits into from
Apr 15, 2020
Merged

spec: unify resource fetching type #953

merged 2 commits into from
Apr 15, 2020

Commits on Apr 9, 2020

  1. spec: unify resource fetching type 

    Dedupe the "remote resource" type from the spec. This came up too during
review of the new HTTP headers. They all had more or less the same
fields in common ("source", "verification", "compression", and more
recently "httpHeaders").

One noticeable spec level change from this is that some places now
support compression where they didn't before. Might seem odd to support
compression for e.g. certificate authorities, though it does make the
spec more consistent throughout.

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
    @bgilbert @jlebon
    bgilbert and jlebon committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    082b454 View commit details
    Browse the repository at this point in the history

  2. tests: add positive tests for resource compression 

    Also verify hashes, to ensure that Ignition's decompress-before-verify
semantics are maintained (coreos#961).
    @bgilbert
    bgilbert committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3660e8c View commit details
    Browse the repository at this point in the history