config/*: drop warning on unset file/dir mode #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
May 13, 2020
lucab
approved these changes
May 14, 2020
arithx
approved these changes
May 14, 2020
The warning was originally added in 424f37b because Ignition spec 2 defaulted to mode 0000, which was certainly not what the user wanted. However, spec 3 defaults to 0755 for dirs and 0644 for files, and is documented as such. It's therefore reasonable for the user to omit those fields, and by issuing the warnings we're encouraging the user to write unnecessarily verbose Ignition configs (or FCCs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning was originally added in #493 because Ignition spec 2 defaulted to mode 0000, which was certainly not what the user wanted. However, spec 3 defaults to 0755 for dirs and 0644 for files, and is documented as such. It's therefore reasonable for the user to omit those fields, and by issuing the warnings we're encouraging the user to write unnecessarily verbose Ignition configs (or FCCs).