Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-zfs-dkms-module example #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twiest
Copy link
Contributor

@twiest twiest commented Sep 3, 2023

Add install-zfs-dkms-module example

  • Add install-zfs-dkms-module example Containerfile and readme
  • Add install-zfs-dkms-module example to main readme
  • Add install-zfs-dkms-module github workflow file
  • Test build install-zfs-dkms-module example

@twiest
Copy link
Contributor Author

twiest commented Sep 3, 2023

Looks like this is failing because fedora-cores stable has kernel version 6.4.7 and the ZFS package requires a maximum kernel version of 6.3.999.

ZFS does this on purpose because the kernel symbols can change and they have to ensure that they work with each version of the kernel.

This will automatically start working once the ZFS package is updated to allow for kernel 6.4.x.

Until then, I'm going to mark this as a draft PR.

@twiest twiest marked this pull request as draft September 3, 2023 19:03
@jmarrero
Copy link
Member

jmarrero commented Sep 5, 2023

Nice, this is a lot simpler than building the module zfs from scratch like we did for: https://github.com/coreos/layering-examples/blob/main/build-zfs-module/Containerfile.

@jmarrero
Copy link
Member

jmarrero commented Sep 5, 2023

I guess we only run CI when someone changes the example, so merging this would not throw a bunch of failures at us every time fedora updates the kernel to a version not supported by ZFS.

- [x] Add install-zfs-dkms-module example Containerfile and readme
- [x] Add install-zfs-dkms-module example to main readme
- [x] Add install-zfs-dkms-module github workflow file
- [x] Test build install-zfs-dkms-module example
@andrewgdunn
Copy link

This works now with the recent release from the upstream zfs project. Thanks for the awesome example.

@jmarrero jmarrero marked this pull request as ready for review November 21, 2023 15:45
@jmarrero
Copy link
Member

@twiest anything new and cool you have done to your Containerfile that you want to update here before I merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants