This repository has been archived by the owner on Sep 24, 2020. It is now read-only.
Rebase 4.18.9 patches onto 4.18.10 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables relocating source and build trees to different roots, provided they stay reachable relative to one another. Useful for builds done within a sandbox where the eventual root is prefixed by some undesirable path component.
…ng boot if kernel is above 4G" On Tue, Jul 03, 2018 at 05:21:50PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 03, 2018 at 03:44:03PM +0300, Kirill A. Shutemov wrote: > > On Tue, Jul 03, 2018 at 01:24:49PM +0200, Gabriel C wrote: > > > 2018-07-01 23:32 GMT+02:00 Benjamin Gilbert <bgilbert@redhat.com>: > > > > On Sun, Jul 01, 2018 at 05:15:59PM -0400, Benjamin Gilbert wrote: > > > >> 4.17 kernels built with the CoreOS Container Linux toolchain and kconfig, > > > >> up to and including 4.17.3, fail to boot on AMD64 running in (at least) > > > >> QEMU/KVM. No messages are shown post-GRUB; the VM instantly reboots. > > > >> Reverting commit 194a974 ("x86/boot/compressed/64: Handle 5-level > > > >> paging boot if kernel is above 4G") fixes it. I've attached our kernel > > > >> config for reference, and am happy to test patches, provide sample QCOW > > > >> images, etc. > > > > > > > > > > Also see https://bugzilla.kernel.org/show_bug.cgi?id=200385 , > > > > > > 0a1756b is acting up > > > too with the same symptoms > > > > I tracked it down to -flto in LDFLAGS. I'll look more into this. > > -flto in LDFLAGS screws up this part of paging_prepare(): +Masahiro, Michal. I've got it wrong. *Any* LDFLAGS option passed to make this way: make LDFLAGS="..." would cause a issue. Even empty. It overrides all assignments to the variable in the makefile. As result the image is built without -pie and linker doesn't generate position independed code. Looks like the patch below helps, but my make-fu is poor. I don't see many override directives in kernel makefiles. It makes me think that there's a better way to fix this. Hm?
This reverts commit c2a9366.
This was referenced Sep 26, 2018
bgilbert
approved these changes
Sep 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.