This repository has been archived by the owner on May 7, 2021. It is now read-only.
kola: add RequiresInternetAccess register flag #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfairley
force-pushed
the
rfairley-internet-flag
branch
from
0efda64
to
3a5dec2
Compare
|
↑ Force pushed a change I committed but didn't push earlier |
arithx
approved these changes
Jan 21, 2019
rfairley
force-pushed
the
rfairley-internet-flag
branch
from
3a5dec2
to
dac7673
Compare
|
↑ Added the list |
arithx
suggested changes
Jan 22, 2019
rfairley
force-pushed
the
rfairley-internet-flag
branch
2 times, most recently
from
a0f1150
to
40e7287
Compare
Tests with this flag set will not be run when running on a platform that does not provide the networking setup required for Internet. Currently, the only platform where this is the case is `"qemu"`. This avoids needing to manually exclude plaforms using `ExcludePlatforms:` for this case. Fixes: coreos#572
rfairley
force-pushed
the
rfairley-internet-flag
branch
from
40e7287
to
bf4bfb8
Compare
arithx
approved these changes
Jan 22, 2019
|
Good to merge from my end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with this flag set will not be run when running on a platform
that does not provide the networking setup required for Internet.
Currently, the only platform where this is the case is
"qemu".This avoids needing to manually exclude platforms using
ExcludePlatforms:for this case.Fixes: #572
A few notes:
I looked at the tests that were already excluding
"qemu". For the tests that did this, I replaced theExcludePlatforms: []string{"qemu"}with the internet flag, apart from the following:These tests look to exclude QEMU for reasons other than requiring Internet access. (security/TLS flakes (3957a90), and SSH tests above not applicable for QEMU).
Added a debug log message to indicate that the test was excluded because Internet is not available. Think it could be helpful, but can understand if having that message would be noisier than we'd like.
Tested this running
kola runon a built QEMU image of CL (built in the CL SDK version 1995.0.0).