Skip to content

Commit

Permalink
upgrader: Generate "computed" origin
Browse files Browse the repository at this point in the history
This is is part of reducing internal complexity - in particular
our "representations of state".  The code here is basically
printing a warning if a requested package is already in the base
tree, and avoid passing that package down to the core.
To accomplish this original code here was doing:

origin -> (computed state) -> treespec

Now that we dropped treespec in a recent PR, it's going:

origin -> (computed state) -> treefile

Instead of having anonymous (computed state) we can
just make that a new (filtered) origin file.  IOW
we now do:

origin -> origin -> treefile

This is easier to understand and debug.  Note
how duplication around checking "requires local
assembly" between the upgrader and origin code
just drops out!
  • Loading branch information
cgwalters committed Jul 13, 2021
1 parent f3dcfd7 commit b41e421
Show file tree
Hide file tree
Showing 3 changed files with 85 additions and 126 deletions.
Loading

0 comments on commit b41e421

Please sign in to comment.