Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update syscore_filter_deployments() for pinning 📌 #1293

Closed
cgwalters opened this issue Mar 8, 2018 · 0 comments
Closed

update syscore_filter_deployments() for pinning 📌 #1293

cgwalters opened this issue Mar 8, 2018 · 0 comments
Assignees
@cgwalters
Labels
bug

Comments

@cgwalters
Copy link
Member

See #1292

I also just noticed rpmostree_syscore_filter_deployments() at least is
going to have to learn about pinning; will need to improve the test suite
around this too.
@cgwalters cgwalters added the bug label Mar 8, 2018
@cgwalters cgwalters self-assigned this Mar 8, 2018
cgwalters added a commit to cgwalters/rpm-ostree that referenced this issue Mar 22, 2018
@cgwalters
daemon: Retain pinned deployments
c466377 
Followup to: ostreedev/ostree#1464

Ideally, we'd delegate more logic around these things to libostree, but we're
not there yet.

This means e.g. `rpm-ostree cleanup -r` for a pinned rollback will just silently
skip it.  It'd be nicer to emit an error probably, but that'd be quite a bit
more work.

Closes: coreos#1293
@cgwalters cgwalters mentioned this issue Mar 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgwalters cgwalters

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgwalters