Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: support URLs to rpms in manifest.json files #1572

Open
dustymabe opened this issue Sep 21, 2018 · 4 comments
Open

RFE: support URLs to rpms in manifest.json files #1572

dustymabe opened this issue Sep 21, 2018 · 4 comments
Assignees
Labels
difficulty/medium medium complexity/difficutly issue kind/enhancement

Comments

@dustymabe
Copy link
Member

similar to #1508 it would be nice if we could just list a URL to an RPM inside a manifest file and have that be picked up during rpm-ostree compose tree. If we do a koji scratch build or something this would skip a few steps: having to download the rpm, make a local repo etc.

related: coreos/coreos-assembler#118

@jlebon
Copy link
Member

jlebon commented Sep 24, 2018

Sounds neat. We'd have to make sure to (1) smartly cache the RPMs (and e.g. use If-Modified-Since), and (2) still respect idempotency if the pkg didn't change.

@dustymabe
Copy link
Member Author

mike has volunteered to work on this to learn more of the ostree/rpm-ostree code bases.

@dustymabe dustymabe added the difficulty/medium medium complexity/difficutly issue label Nov 1, 2018
@mike-nguyen
Copy link
Member

Sorry it took a while to get up to speed. There's so many different parts to the compose but I think I've finally got to a point where I can actually work on this card instead of just tinkering with the code. Before I dive headfirst, @jlebon--do you have any thoughts into the addition of the URLs? Is it better to allow URLs in the packages list in the manifest or create a new list for URLs?

@jlebon
Copy link
Member

jlebon commented Dec 3, 2018

Offhand, I think supporting it directly in the packages list would be OK? Just random thoughts on this:
one way to implement this would be to download all the pkgs to a new dir in the cache dir. And then respect the same semantics as rpm-md repos, i.e. --cache-only won't retry fetching then, while without --cache-only, we refetch (though a nice follow-up would be to only refetch if it changed).

mike-nguyen added a commit to mike-nguyen/rpm-ostree that referenced this issue Feb 22, 2019
This allows URLs to be used in the manifest file when doing a
treecompose only in unified-core mode.  This is a convenient way of
adding one off packages for testing purposes but should not be the
preferred method of composing a tree.

Closes: coreos#1572
@dustymabe dustymabe removed the jira for syncing to jira label Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium medium complexity/difficutly issue kind/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants